timsaucer commented on code in PR #1398:
URL:
https://github.com/apache/datafusion-python/pull/1398#discussion_r3002671893
##########
.github/workflows/build.yml:
##########
@@ -73,7 +73,7 @@ jobs:
enable-cache: true
- name: Install dependencies
- run: uv sync --dev --no-install-package datafusion
+ run: uv sync --locked --dev --no-install-package datafusion
Review Comment:
I don't think that's strictly necessary. The check has been added to
`lint-python` job that is a dependency of each of the other jobs where a sync
occurs. So it will fail early in the pipeline if the uv lock is not up to date
and those other jobs will never run.
If you think it's necessary for completeness sake, and in case we were to
ever remove the `lint-python` job that's a different story. But personally I
believe @mesejo 's solution will correctly enforce the requirement he's set out
to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
