andygrove opened a new pull request, #3830: URL: https://github.com/apache/datafusion-comet/pull/3830
## Which issue does this PR close? N/A - minor diff consistency fix. ## Rationale for this change The `filter pushdown - StringPredicate` test in the 3.4.3 Spark SQL test diff uses `IgnoreCometNativeDataFusion` while the same test in the 3.5.8 and 4.0.1 diffs uses `IgnoreCometNativeScan`. The test fails because the native scan doesn't propagate the `NumRowGroupsAcc` Spark accumulator, so `IgnoreCometNativeScan` is the more appropriate tag. ## What changes are included in this PR? Changed the tag on the "filter pushdown - StringPredicate" test in `dev/diffs/3.4.3.diff` from `IgnoreCometNativeDataFusion` to `IgnoreCometNativeScan` for consistency with the other Spark version diffs. ## How are these changes tested? Verified the test still fails with `COMET_PARQUET_SCAN_IMPL=native_datafusion` (accumulator returns 0), confirming the ignore tag is still needed. The change only narrows the scope of the ignore to match the other diffs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
