kazuyukitanimura commented on code in PR #3830:
URL: https://github.com/apache/datafusion-comet/pull/3830#discussion_r3011160616


##########
dev/diffs/3.4.3.diff:
##########
@@ -2069,7 +2069,7 @@ index 104b4e416cd..d865077684f 100644
  
 -  test("filter pushdown - StringPredicate") {
 +  test("filter pushdown - StringPredicate",
-+    IgnoreCometNativeDataFusion("cannot be pushed down")) {
++    IgnoreCometNativeScan("cannot be pushed down")) {

Review Comment:
   Thanks.
   
   Is https://github.com/apache/datafusion-comet/issues/3321 the tracking issue?
   
   `The test fails because the native scan doesn't propagate the 
NumRowGroupsAcc Spark accumulator` So sounds like the gap is still there even 
it is not a bug? I was thinking we can include the link like 
`IgnoreCometNativeScan("https://github.com/apache/datafusion-comet/issues/3321";)`
 so that we can revisit, just like other skipped tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to