jayzhan211 commented on PR #11516: URL: https://github.com/apache/datafusion/pull/11516#issuecomment-2239003792
I doubt that `CatalogSession` solves all the dependencies issue. `CatalogSession` is one higher level trait out of core. Others implementations are still leave inside core. If we want to move TableProvider implementation out of core into `datasource`, since we still need to downcast `CatalogSession` to `SessionState`, thus `SessionState` should be in the same as `datasource`, the same issue applied to other actual implementation like Catalog. We can actually bring `TableProvider`+`CatalogProvider`+`SessionState`+Others related things out of core into it's own crate without `CatalogSession`, but the dependencies between `TableProvider`, `CatalogProvider` and `SessionState` are what left to be decoupled. And, I don't think `CatalogSession` is enough 🤔 Did I miss something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
