alamb commented on PR #11516: URL: https://github.com/apache/datafusion/pull/11516#issuecomment-2241076641
> At runtime there are circular dependencies, unless we further limit amount of functionality available to the `TableProvider`. However, I think we actually solve the circular dependencies with indirection. `CatalogSession` is supposed to be a POC for that indirection. Yes I agree with this > Instead, I think we should provider insert_plan_to_table for SchemaProvider. And avoid insert plan inside QueryPlan but in SchemaProvider. Split the logic into two step with I also think this sounds like a reasonable plan - and I think it becomes easier as we split the logic out and defined the API via trats -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
