Dandandan commented on code in PR #20500:
URL: https://github.com/apache/datafusion/pull/20500#discussion_r3005999845
##########
datafusion/physical-plan/src/common.rs:
##########
@@ -204,6 +205,31 @@ pub fn can_project(
}
}
+/// Return a new `RecordBatch` with [`StringViewArray::gc`] called on such
columns (if any).
+pub(crate) fn gc_stringview_arrays(
+ batch: RecordBatch,
+) -> Result<RecordBatch, ArrowError> {
+ let mut new_columns: Vec<Arc<dyn Array>> =
Vec::with_capacity(batch.num_columns());
+
+ let mut arr_mutated = false;
+ for array in batch.columns() {
+ if let Some(string_view_array) =
array.as_any().downcast_ref::<StringViewArray>()
+ {
+ let new_array = string_view_array.gc();
Review Comment:
Yes, I think in theory it should be slightly better to do the coalescing
directly when batches are potentially already in cache & saving partition - 1 *
wake ups (which are not used).
But it seems (my theory) pushing it upstream might create some parallelism /
mitigating some skew as also for a slow partition it can do the coalescing in
parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
