neilconway commented on code in PR #21240:
URL: https://github.com/apache/datafusion/pull/21240#discussion_r3011629793


##########
datafusion/physical-plan/src/scalar_subquery.rs:
##########
@@ -237,6 +237,10 @@ impl ExecutionPlan for ScalarSubqueryExec {
         self.true_for_input_only()
     }
 
+    fn partition_statistics(&self, partition: Option<usize>) -> 
Result<Arc<Statistics>> {
+        self.input.partition_statistics(partition)

Review Comment:
   Sorry, I want to make sure I understand. `partition_statistics` is about the 
statistics for the *output* of the plan node. The output of 
`ScalarSubqueryExec` is identical to the output of its main input child node; 
the n other children are just subqueries whose result values get used somewhere 
by the main input plan. The statistics of the child subqueries don't direct 
influence the properties of the output of the `ScalarSubqueryExec` itself. Lmk 
if I'm misunderstanding you though!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to