Dandandan commented on code in PR #21240:
URL: https://github.com/apache/datafusion/pull/21240#discussion_r3011689813
##########
datafusion/physical-plan/src/scalar_subquery.rs:
##########
@@ -237,6 +237,10 @@ impl ExecutionPlan for ScalarSubqueryExec {
self.true_for_input_only()
}
+ fn partition_statistics(&self, partition: Option<usize>) ->
Result<Arc<Statistics>> {
+ self.input.partition_statistics(partition)
Review Comment:
My thoughy was if this is the physical node for scalar subquery (which
returns 1 row maximum and returns error if it exceeeds 1 row)? If so, we could
update the statistics (based on child stats) to be min(1, child).
Will try to look at the PR more in depth tomorrow!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
