funcpp opened a new pull request, #2288: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2288
## Summary - Change `parse_tuple(false, true)` to `parse_tuple(true, true)` for GROUPING SETS in `parse_group_by_expr`, matching CUBE and ROLLUP GROUPING SETS required each element to be parenthesized, while CUBE and ROLLUP already accepted bare columns. This meant valid syntax like `GROUPING SETS (a, b, c)` failed to parse. The [PostgreSQL grammar](https://www.postgresql.org/docs/current/queries-table-expressions.html#QUERIES-GROUPING-SETS) explicitly allows `expression` as a grouping element. The modifier path (added in #1653) already uses `parse_tuple(true, true)` for GROUPING SETS — this PR fixes the expression path to be consistent. ## Test plan - [x] New test: bare columns and mixed bare/parenthesized elements - [x] Existing GROUPING SETS tests unaffected - [x] Full test suite passes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
