kazuyukitanimura opened a new pull request, #3848: URL: https://github.com/apache/datafusion-comet/pull/3848
## Which issue does this PR close? Closes #1729 ## Rationale for this change #1729 was opened due to PR #1728 (comment https://github.com/apache/datafusion-comet/pull/1728#discussion_r2082843668) Later #3675 disabled `ceil` and `floor` for decimals. However, the rust test cases added in #1728 are incorrect in my opinion. When spark `ceil`/`floor`, Spark changes precision and scale. And later result precision and scale are set at https://github.com/apache/datafusion-comet/blob/main/native/spark-expr/src/math_funcs/ceil.rs#L51 The output of `decimal_ceil_f` is intermediate result. Therefore. `decimal_ceil_f` is correct and the expected values of rust test cases are incorrect. ## What changes are included in this PR? Corrected the rust test cases. Enabled `ceil` and `floor` again ## How are these changes tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
