zhuqi-lucas opened a new pull request, #21268:
URL: https://github.com/apache/datafusion/pull/21268

   ## Which issue does this PR close?
   
   N/A (build improvement)
   
   ## Rationale for this change
   
   `datafusion-substrait` is a heavyweight dependency that most developers and 
users don't need. Making it optional saves compile time for the common case.
   
   ## What changes are included in this PR?
   
   - `datafusion-substrait` is now an optional dependency in 
`datafusion-sqllogictest/Cargo.toml`
   - New `substrait` feature flag gates the dependency
   - `#[cfg(feature = "substrait")]` gates the module, imports, and 
`run_test_file_substrait_round_trip` function
   - No-op fallback function returns an error when the feature is disabled
   - CI workflow updated to pass `--features substrait` for the round-trip test
   
   ## Are these changes tested?
   
   - Compiles without `substrait` feature (default)
   - Compiles with `--features substrait`
   - CI substrait round-trip test updated to enable the feature
   
   ## Are there any user-facing changes?
   
   No — this only affects the sqllogictest binary, not the datafusion library 
itself. The substrait round-trip test requires `--features substrait` to run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to