Copilot commented on code in PR #21268:
URL: https://github.com/apache/datafusion/pull/21268#discussion_r3013970567
##########
.github/workflows/rust.yml:
##########
@@ -537,7 +537,7 @@ jobs:
# command cannot be run for all the .slt files. Run it for just one
that works (limit.slt)
# until most of the tickets in
https://github.com/apache/datafusion/issues/16248 are addressed
# and this command can be run without filters.
- run: cargo test --test sqllogictests -- --substrait-round-trip
limit.slt
+ run: cargo test --test sqllogictests --features substrait --
--substrait-round-trip limit.slt
Review Comment:
The `cargo test --test sqllogictests --features substrait ...` invocation is
run from the workspace root in a virtual workspace. Adding `--features
substrait` here is likely to fail because features must be applied to a
specific package (e.g. `--package datafusion-sqllogictest`) or by running the
command from `datafusion/sqllogictest/`. Consider updating this step to either
`cd datafusion/sqllogictest` before running, or add `--package
datafusion-sqllogictest` (and optionally `--profile ci` to match other CI
invocations).
```suggestion
run: cargo test -p datafusion-sqllogictest --test sqllogictests
--features substrait -- --substrait-round-trip limit.slt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
