timsaucer commented on code in PR #21263:
URL: https://github.com/apache/datafusion/pull/21263#discussion_r3021956680
##########
datafusion/physical-expr/src/scalar_function.rs:
##########
@@ -169,16 +169,10 @@ impl ScalarFunctionExpr {
/// Otherwise returns `Some(ScalarFunctionExpr)`.
pub fn try_downcast_func<T>(expr: &dyn PhysicalExpr) ->
Option<&ScalarFunctionExpr>
where
- T: 'static,
+ T: ScalarUDFImpl,
Review Comment:
This may look like it's changing behavior because we're changing the generic
but if you look at the usage, the downcast must be to a ScalarUDFImpl so this
is valid IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
