timsaucer commented on code in PR #21263:
URL: https://github.com/apache/datafusion/pull/21263#discussion_r3022051343
##########
datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs:
##########
@@ -547,7 +547,9 @@ async fn verify_ordered_aggregate(frame: &DataFrame,
expected_sort: bool) {
type Node = Arc<dyn ExecutionPlan>;
fn f_down(&mut self, node: &'n Self::Node) ->
Result<TreeNodeRecursion> {
- if let Some(exec) = node.as_any().downcast_ref::<AggregateExec>() {
+ if let Some(exec) =
Review Comment:
Thank you for the push back @alamb. If you take another look, I think we now
have a very clean downcast. I also updated the UDFs at the same time and
applied the pattern. They have many fewer places where we do `downcast_ref` or
`is` so it wasn't so noticeable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
