Blizzara commented on code in PR #11547:
URL: https://github.com/apache/datafusion/pull/11547#discussion_r1685003113
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -236,6 +236,40 @@ fn hash_struct_array(
Ok(())
}
+fn hash_map_array(
+ array: &MapArray,
+ random_state: &RandomState,
+ hashes_buffer: &mut [u64],
+) -> Result<()> {
+ let nulls = array.nulls();
+ let offsets = array.offsets();
+
+ // Create hashes for each entry in each row
+ let mut values_hashes = vec![0u64; array.entries().len()];
+ create_hashes(array.entries().columns(), random_state, &mut
values_hashes)?;
+
+ // Combine the hashes for entries on each row with each other and previous
hash for that row
Review Comment:
I adapted this logic from combining List and Struct hashing, the result
seemed to make sense to me, but I'm not 100% confident in it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
