alamb commented on code in PR #11547:
URL: https://github.com/apache/datafusion/pull/11547#discussion_r1686995057
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -692,6 +730,48 @@ mod tests {
assert_eq!(hashes[0], hashes[1]);
}
+ #[test]
+ // Tests actual values of hashes, which are different if forcing collisions
+ #[cfg(not(feature = "force_hash_collisions"))]
+ fn create_hashes_for_map_arrays() {
Review Comment:
It would help me undertand / verify this test if you could use a
`MapBuilder` or add a comment showing what MapArray was being built
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -1773,6 +1773,7 @@ impl ScalarValue {
}
DataType::List(_)
| DataType::LargeList(_)
+ | DataType::Map(_, _)
Review Comment:
this is fine I think because `ScalarValue::Map` is implemented as a 1 row
array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
