andygrove commented on code in PR #3781:
URL: https://github.com/apache/datafusion-comet/pull/3781#discussion_r3024162164
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -168,8 +168,13 @@ case class CometScanRule(session: SparkSession)
COMET_NATIVE_SCAN_IMPL.get() match {
case SCAN_AUTO =>
- // TODO add support for native_datafusion in the future
- nativeIcebergCompatScan(session, scanExec, r, hadoopConf)
+ nativeDataFusionScan(plan, session, scanExec, r, hadoopConf)
+ .orElse {
+ // clear explain info tags from the failed nativeDataFusionScan
+ // attempt so they don't leak into the fallback path
+ scanExec.unsetTagValue(CometExplainInfo.EXTENSION_INFO)
Review Comment:
An alternative approach is for auto mode to just try `native_datafusion` and
then fall back to Spark, rather than try `native_iceberg_compat` first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
