comphead commented on code in PR #3781:
URL: https://github.com/apache/datafusion-comet/pull/3781#discussion_r3028832445
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -188,6 +184,12 @@ case class CometScanRule(session: SparkSession)
scanExec: FileSourceScanExec,
r: HadoopFsRelation,
hadoopConf: Configuration): Option[SparkPlan] = {
+ if (!COMET_EXEC_ENABLED.get()) {
+ withInfo(
+ scanExec,
+ s"$SCAN_NATIVE_DATAFUSION scan requires ${COMET_EXEC_ENABLED.key} to
be enabled")
+ return None
+ }
if (!CometNativeScan.isSupported(scanExec)) {
return None
Review Comment:
should we also add `withInfo` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
