kosiew commented on code in PR #21151:
URL: https://github.com/apache/datafusion/pull/21151#discussion_r3025716160
##########
datafusion/functions-aggregate/src/min_max.rs:
##########
@@ -1270,4 +1270,104 @@ mod tests {
assert_eq!(max_result, ScalarValue::Utf8(Some("🦀".to_string())));
Ok(())
}
+
+ fn dict_scalar(key_type: DataType, inner: ScalarValue) -> ScalarValue {
Review Comment:
The three new tests look good, but they repeat the same dictionary array
setup pattern.
A small helper that builds a `DictionaryArray` and `ArrayRef` pair could
make these tests easier to read and keep future dictionary min/max cases
cheaper to add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
