mbutrovich commented on code in PR #3842:
URL: https://github.com/apache/datafusion-comet/pull/3842#discussion_r3028907077
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometMetricNode.scala:
##########
@@ -79,6 +89,7 @@ case class CometMetricNode(metrics: Map[String, SQLMetric],
children: Seq[CometM
}
}
+ // Called via JNI from `comet_metric_node.rs`
Review Comment:
Is that the only place this will ever be called from? Otherwise I'm not sure
the comment is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
