mbutrovich commented on PR #3842: URL: https://github.com/apache/datafusion-comet/pull/3842#issuecomment-4193127618
> `CometNativeScanExec.doExecuteColumnar` by some reason is not called for native scans, which might require another investigation ticket(@mbutrovich WDYT?) This makes sense after looking at it more. We call `doExecuteColumnar` on the top node in a sequence of native operators, which is almost never `CometNativeScanExec`. My only comment at this point is should we be looking for all native scan children (as mentioned, union can have multiple native scans) not just the first native scan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
