tshauck opened a new pull request, #11559: URL: https://github.com/apache/datafusion/pull/11559
## Which issue does this PR close? Closes #11552 ## Rationale for this change The `assert!(datatype.is_primitive());` is getting hit in `new_negative_one`, but as far as I can tell isn't needed. There's a match statement right below that handles the datatype. Without the assert these functions seem to work properly ## What changes are included in this PR? Removed `datatype.is_primative()` asserts where the datatype is immediately matched on. I think it'd generally be better to handle unexpected datatypes that way for the error propagation vs asserting, which can lead to panics at query time. ## Are these changes tested? I added tests from the ticket that were reported as panicking. ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
