alamb commented on code in PR #11559:
URL: https://github.com/apache/datafusion/pull/11559#discussion_r1685384318
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -1063,7 +1063,6 @@ impl ScalarValue {
/// Create an one value in the given type.
pub fn new_one(datatype: &DataType) -> Result<ScalarValue> {
- assert!(datatype.is_primitive());
Review Comment:
removing the assert (as any unhandled type will cause a runtime error) makes
a lot of sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
