pgwhalen commented on PR #21250:
URL: https://github.com/apache/datafusion/pull/21250#issuecomment-4181098533
Thoughts for reviewers:
#### Does it make sense to include both examples?
I thought it was valuable to show both the pruning predicate method as well
as literal guarantees directly, since my personal experience was that the
pruning predicate was an unnecessary layer for me and I wanted to see the most
direct way to get something useful from the filter expressions.
I'm also aware that
[parquet_advanced_index.rs](https://github.com/apache/datafusion/blob/main/datafusion-examples/examples/data_io/parquet_advanced_index.rs)
has a lot of overlap with the pruning predicate example, so perhaps it makes
sense to omit that. Though I think there's value in an example that doesn't
show anything parquet specific and just focuses on generic partition
elimination.
#### Should I reuse the code across examples (i.e. `User` struct, etc.)?
The other examples were pretty standalone so I followed that pattern, but
obviously it's easy to switch.
#### Claude disclosure
This mostly Claude Code generated initially, but all reviewed/tweaked by me.
Please let me know if it feels too LLM-ish still, I
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
