jayzhan211 commented on issue #11546: URL: https://github.com/apache/datafusion/issues/11546#issuecomment-2240917287
> @jayzhan211 I have drafted a PR #11560 for it. The design differs from your proposal, but it makes sense to me. Could you take a look at it? > > The core concept is providing an expression function and wrapping `make_array` for the arguments. I think we don't need to change the argument format of `MapFunc`. However, we need to move `map.rs` to `functions-array` because it needs `make_array`. > > Maybe we can rename `functions-array` to `functions-collection`? I think there are many implementations that could be shared if we want to support more collection types and usage. My concern is that it might be slower because of additional `make_array()` computation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
