jayzhan211 commented on issue #11546: URL: https://github.com/apache/datafusion/issues/11546#issuecomment-2240997123
Ideally MapFunc should have the arguments that have minimum transformation and computation cost for creating StructArray, so we can get the most efficient implementation. 1. k1, v1, k2, v2... is not ideal because we need to arrange it to k1, k2, ... v1, v2 ..., that is why initial MakeMap is beaten by MapFunc. 2. current implementation has the additional cost of `make_array` transformation, I guess we could do better without it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
