LiaCastaneda commented on code in PR #21350:
URL: https://github.com/apache/datafusion/pull/21350#discussion_r3033335877
##########
datafusion/physical-plan/src/buffer.rs:
##########
@@ -298,6 +322,26 @@ impl ExecutionPlan for BufferExec {
}
}
+/// Walks the plan tree rooted at `plan` and collects all
[`DynamicFilterPhysicalExpr`]s
+/// with [`ProducerKind::HashJoin`] found in expressions of any node in the
subtree.
+fn collect_hash_join_dynamic_filters(
+ plan: &dyn ExecutionPlan,
+) -> Vec<DynamicFilterPhysicalExpr> {
+ let mut filters = vec![];
+ let _ = plan.apply_expressions(&mut |expr| {
+ if let Some(df) =
expr.as_any().downcast_ref::<DynamicFilterPhysicalExpr>()
+ && df.producer_kind() == ProducerKind::HashJoin
Review Comment:
We need to know who the producer is, otherwise if we wait on a dynamic
filter from a `TopK` (or `AggregateExec`) we can enter a deadlock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
