timsaucer commented on code in PR #21346:
URL: https://github.com/apache/datafusion/pull/21346#discussion_r3033809998
##########
datafusion/ffi/src/catalog_provider.rs:
##########
@@ -85,12 +84,12 @@ unsafe impl Send for FFI_CatalogProvider {}
unsafe impl Sync for FFI_CatalogProvider {}
struct ProviderPrivateData {
- provider: Arc<dyn CatalogProvider + Send>,
Review Comment:
CatalogProvider is already Send so this is unnecessary
##########
datafusion/ffi/src/catalog_provider_list.rs:
##########
@@ -75,12 +74,12 @@ unsafe impl Send for FFI_CatalogProviderList {}
unsafe impl Sync for FFI_CatalogProviderList {}
struct ProviderPrivateData {
- provider: Arc<dyn CatalogProviderList + Send>,
Review Comment:
CatalogProviderList is already Send so this is unnecessary
##########
datafusion/ffi/src/table_provider.rs:
##########
@@ -159,12 +158,12 @@ unsafe impl Send for FFI_TableProvider {}
unsafe impl Sync for FFI_TableProvider {}
struct ProviderPrivateData {
- provider: Arc<dyn TableProvider + Send>,
Review Comment:
TableProvider is already Send so this is unnecessary
##########
datafusion/ffi/src/schema_provider.rs:
##########
@@ -91,12 +90,12 @@ unsafe impl Send for FFI_SchemaProvider {}
unsafe impl Sync for FFI_SchemaProvider {}
struct ProviderPrivateData {
- provider: Arc<dyn SchemaProvider + Send>,
Review Comment:
SchemaProvider is already Send so this is unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
