alamb commented on code in PR #21355: URL: https://github.com/apache/datafusion/pull/21355#discussion_r3035659443
########## datafusion/sqllogictest/test_files/set_variable.slt: ########## @@ -379,6 +379,204 @@ RESET datafusion.execution.batches_size statement error DataFusion error: Invalid or Unsupported Configuration: Config field is a scalar usize and does not have nested field "bar" RESET datafusion.execution.batch_size.bar +############################################# +## Test datafusion.format.* configurations ## +############################################# +query T +SELECT name FROM information_schema.df_settings WHERE name LIKE 'datafusion.format.%' ORDER BY name Review Comment: In addition to tests showing that they can be set/removed, how about also adding tests that run a function that is affected by them (e.g. select a date and then show that changing datafusion.format.date changes how they are displayed)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
