erenavsarogullari commented on code in PR #21355: URL: https://github.com/apache/datafusion/pull/21355#discussion_r3037070430
########## datafusion/sqllogictest/test_files/set_variable.slt: ########## @@ -379,6 +379,204 @@ RESET datafusion.execution.batches_size statement error DataFusion error: Invalid or Unsupported Configuration: Config field is a scalar usize and does not have nested field "bar" RESET datafusion.execution.batch_size.bar +############################################# +## Test datafusion.format.* configurations ## +############################################# +query T +SELECT name FROM information_schema.df_settings WHERE name LIKE 'datafusion.format.%' ORDER BY name Review Comment: @alamb Thanks for the review and yes, we also need to add more functional coverage as follows: **Expected Behavior:** ``` statement ok SET datafusion.format.date_format = '%d-%m-%Y' query D SELECT DATE '2024-03-15' ---- 15-03-2024 statement ok RESET datafusion.format.date_format query D SELECT DATE '2024-03-15' ---- 2024-03-15 ``` However, currently, sqllogictest framework does not support `custom` format updates and it runs the test with `default` format settings and the results as follows: **Current Behavior:** ``` statement ok SET datafusion.format.date_format = '%d-%m-%Y' query D SELECT DATE '2024-03-15' ---- Returns 2024-03-15 instead of 15-03-2024 ``` The reason is that and `sqllogictest framework` needs to be extended in order to uptake format settings by `SessionContext` instead default format settings: https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs#L239. I need to have a look on this. Does it make sense to be merged current PR and extend `sqllogictest framework` and adding remaining functional tests by follow-up PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
