crm26 commented on PR #21363:
URL: https://github.com/apache/datafusion/pull/21363#issuecomment-4202658920
Found and fixed the CI failure, pushed as 92884480a.
The `cargo test (amd64)` / `(macos-aarch64)` failures came from a stale
negative test in `predicates.slt:845` that asserted `NULL IN (SELECT ... FROM
empty)` in a projection would error with "Physical plan does not support
logical expression InSubquery". With decorrelation now supported in
projections, the query correctly returns `(false, true)` — updated the test to
expect the correct result.
My earlier validation gap: I only ran `cargo test --test sqllogictests --
subquery.slt` locally and didn't catch the stale test in `predicates.slt`. My
fault — should have run the full slt suite. I've now run:
- `cargo test -p datafusion-optimizer` — 665 + 26 + 5 pass
- `cargo test --test sqllogictests` (all 422 files) — all pass
- `cargo test --test sqllogictests -- --include-sqlite` (1017 files) — all
pass
- `cargo test -p datafusion-cli --features datafusion/extended_tests` —
25/25 pass
- `cargo fmt --check` + `cargo clippy -D warnings` — clean
CI on the new commit is currently in `action_required` state — could you
kick off the workflow run when you get a chance?
On the rename suggestion ("Predicate" → "ExistsInSubquery") — happy to do
that, agreed a followup PR makes sense to keep this one focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
