neilconway commented on PR #21363: URL: https://github.com/apache/datafusion/pull/21363#issuecomment-4202849692
@crm26 Thanks for iterating on this! The comment I was suggesting you add "Optimization:" to was actually a different one :) My suggestion was attached to the "// Skip if no predicate subqueries in any projection expression" check at the top of the "Projection" match arm. I noticed you didn't address my suggestion to simplify the cloning / early-return code path; let me know if what I'm suggesting isn't clear. I don't have permissions to run CI myself, but perhaps @alamb or someone else can help. BTW I personally find it helpful to "Resolve comment" on review comments that you believe have been addressed, so we can more easily see what remains open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
