alamb opened a new pull request, #21486: URL: https://github.com/apache/datafusion/pull/21486
- Draft as it builds on https://github.com/apache/datafusion/pull/21379 ## Which issue does this PR close? - Follow on tp https://github.com/apache/datafusion/pull/21379 from @Dandandan ## Rationale for this change https://github.com/apache/datafusion/pull/21379 adds a specific optimization, but it had some non trivial code duplication I wanted to reduce the duplication and also make the code easier to read(in my opinion) ## What changes are included in this PR? Move the special RegExp logic into its own struct, and add copious comments ## Are these changes tested? By existing tests, and the additional tests added in - https://github.com/apache/datafusion/pull/21485 ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
