0lai0 commented on code in PR #3804: URL: https://github.com/apache/datafusion-comet/pull/3804#discussion_r3063402086
########## native/spark-expr/src/datetime_funcs/hours.rs: ########## @@ -0,0 +1,274 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Spark-compatible `hours` V2 partition transform. +//! +//! Computes the number of hours since the Unix epoch (1970-01-01 00:00:00 UTC). +//! +//! Both `TimestampType` and `TimestampNTZType` are computationally identical. They +//! extract the absolute hours since the epoch by directly dividing the microsecond +//! value by the number of microseconds in an hour, ignoring session timezone offsets. + +use arrow::array::cast::as_primitive_array; +use arrow::array::types::TimestampMicrosecondType; +use arrow::array::{Array, Int32Array}; +use arrow::datatypes::{DataType, TimeUnit::Microsecond}; +use datafusion::common::{internal_datafusion_err, DataFusionError}; +use datafusion::logical_expr::{ + ColumnarValue, ScalarFunctionArgs, ScalarUDFImpl, Signature, Volatility, +}; +use std::{any::Any, fmt::Debug, sync::Arc}; + +const MICROS_PER_HOUR: i64 = 3_600_000_000; + +#[derive(Debug, PartialEq, Eq, Hash)] +pub struct SparkHoursTransform { + signature: Signature, +} + +impl SparkHoursTransform { + pub fn new() -> Self { + Self { + signature: Signature::user_defined(Volatility::Immutable), + } + } +} + +impl ScalarUDFImpl for SparkHoursTransform { + fn as_any(&self) -> &dyn Any { + self + } + + fn name(&self) -> &str { + "hours_transform" + } + + fn signature(&self) -> &Signature { + &self.signature + } + + fn return_type(&self, _arg_types: &[DataType]) -> datafusion::common::Result<DataType> { + Ok(DataType::Int32) + } + + fn invoke_with_args( + &self, + args: ScalarFunctionArgs, + ) -> datafusion::common::Result<ColumnarValue> { + let args: [ColumnarValue; 1] = args.args.try_into().map_err(|_| { + internal_datafusion_err!("hours_transform expects exactly one argument") + })?; + + match args { + [ColumnarValue::Array(array)] => { + let ts_array = as_primitive_array::<TimestampMicrosecondType>(&array); + let result: Int32Array = match array.data_type() { + DataType::Timestamp(Microsecond, _) => { + arrow::compute::kernels::arity::unary(ts_array, |micros| { + micros.div_euclid(MICROS_PER_HOUR) as i32 Review Comment: Updated to use div_floor to match the rest of the codebase. Thanks for pointing this out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
