coderfender commented on code in PR #21456:
URL: https://github.com/apache/datafusion/pull/21456#discussion_r3073898473
##########
datafusion/functions-aggregate-common/src/aggregate/count_distinct/native.rs:
##########
@@ -78,6 +78,7 @@ where
])
}
+ #[inline(never)]
Review Comment:
Yes . inlining didn't really help with the optimization and made it worse
with existing i64 paths (benchmarks above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
