findepi commented on code in PR #11516:
URL: https://github.com/apache/datafusion/pull/11516#discussion_r1686740306
##########
datafusion/core/src/datasource/listing_table_factory.rs:
##########
@@ -49,16 +49,18 @@ impl ListingTableFactory {
impl TableProviderFactory for ListingTableFactory {
async fn create(
&self,
- state: &SessionState,
+ state: &dyn CatalogSession,
cmd: &CreateExternalTable,
) -> Result<Arc<dyn TableProvider>> {
- let file_format = state
+ // TODO remove downcast_ref from here. Should file format factory be
an extension to session state?
Review Comment:
also filed https://github.com/apache/datafusion/issues/11600 for this
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -736,13 +736,16 @@ impl TableProvider for ListingTable {
async fn scan(
&self,
- state: &SessionState,
+ state: &dyn CatalogSession,
projection: Option<&Vec<usize>>,
filters: &[Expr],
limit: Option<usize>,
) -> Result<Arc<dyn ExecutionPlan>> {
- let (mut partitioned_file_lists, statistics) =
- self.list_files_for_scan(state, filters, limit).await?;
+ // TODO remove downcast_ref from here?
Review Comment:
filed https://github.com/apache/datafusion/issues/11600 for downcasts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
