findepi commented on PR #11516: URL: https://github.com/apache/datafusion/pull/11516#issuecomment-2243062441
> we might need more granular trait than single CatalogSession for each trait I agree with you @jayzhan211 that having separate traits for TableProvider, CatalogProvider, SchemaProvider is the most flexible approach. Whether additional flexibility is worth additional complexity cost should depend on whether the additional flexibility provides actual value. For example, if all these traits are always implemented in core and always based on `SessionState`, then more flexibility didn't buy us much. However, if one could use TableProvider without CatalogProvider (or vice versa), or could use this components without core (and thus without `SessionState`), then additional flexibility would mean smaller interface surface to implement. Does this make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
