yonatan-sevenai commented on PR #21593: URL: https://github.com/apache/datafusion/pull/21593#issuecomment-4239528839
> Thanks @yonatan-sevenai. I think there is another PR that adds support for the Snowflake dialect from @goldmedal (#20648). Maybe you could collaborate together on one of the PRs to avoid duplicate work. Thanks! Quite the find :) I believe the implementation I added covers many more use cases, but we'll see if we can collaborate on a single implementation. Specifically, there's a lot of complexity when the array to unnest is the result of a UDF, Subquery, and things like that? I saw a lot of edge cases where the optimizer might include limits and sorts between the unnest and the TableScan / SubqueryAlias as well and some complexity when you need to cross join the original table. Hope we can figure out a single stable implementation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
