andygrove commented on PR #3866: URL: https://github.com/apache/datafusion-comet/pull/3866#issuecomment-4239874989
> Not against for this change, but do we plan to add dictionary encoded parquet tests for the sql tests in the future? I don't think it will make sense to use the sql test file approach to test for dictionary encoded parquet because we would have to insert large amounts of data to trigger dictionary encoding. I think it is better to rely on the Scala tests for dictionary encoding tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
