timsaucer commented on code in PR #1484:
URL: 
https://github.com/apache/datafusion-python/pull/1484#discussion_r3080300798


##########
python/datafusion/functions.py:
##########
@@ -2300,25 +2350,29 @@ def extract(part: Expr, date: Expr) -> Expr:
     return date_part(part, date)
 
 
-def date_trunc(part: Expr, date: Expr) -> Expr:
+def date_trunc(part: Expr | str, date: Expr) -> Expr:
     """Truncates the date to a specified level of precision.
 
+    Args:
+        part: The precision to truncate to. Must be one of ``"year"``,

Review Comment:
   https://github.com/apache/datafusion-python/issues/1496



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to