adriangb commented on code in PR #21527: URL: https://github.com/apache/datafusion/pull/21527#discussion_r3083425618
########## datafusion/sqllogictest/test_files/joins.slt: ########## @@ -4463,7 +4473,8 @@ physical_plan 04)------FilterExec: b@1 > 3, projection=[a@0] 05)--------DataSourceExec: partitions=2, partition_sizes=[1, 1] 06)----SortExec: expr=[c@2 DESC NULLS LAST], preserve_partitioning=[true] -07)------DataSourceExec: partitions=2, partition_sizes=[1, 1] +07)------FilterExec: DynamicFilter [ empty ] Review Comment: Makes sense. I think it would be valuable to have some tests with a parquet source where the dynamic filter is pushed through. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
