Jefffrey commented on code in PR #21455:
URL: https://github.com/apache/datafusion/pull/21455#discussion_r3090932493
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -1015,6 +1015,16 @@ impl DataFrame {
//the functions now supported
let supported_describe_functions =
vec!["count", "null_count", "mean", "std", "min", "max", "median"];
+ let supports_describe_min_max = |data_type: &DataType| {
+ !matches!(
+ data_type,
+ DataType::Boolean
+ | DataType::Binary
+ | DataType::LargeBinary
+ | DataType::BinaryView
+ | DataType::FixedSizeBinary(_)
Review Comment:
use
[`is_binary`](https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html#method.is_binary)
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
