xanderbailey commented on code in PR #20813:
URL: https://github.com/apache/datafusion/pull/20813#discussion_r3091234467
##########
datafusion/common/src/parsers.rs:
##########
@@ -73,3 +73,48 @@ impl CompressionTypeVariant {
!matches!(self, &Self::UNCOMPRESSED)
}
}
+
+/// CSV quote style
+///
+/// Controls when fields are quoted when writing CSV files.
+/// Corresponds to [`arrow::csv::QuoteStyle`].
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Default)]
+pub enum CsvQuoteStyle {
+ /// Quote all fields
+ Always,
+ /// Only quote fields when necessary (default)
+ #[default]
+ Necessary,
+ /// Quote all non-numeric fields
+ NonNumeric,
+ /// Never quote fields
+ Never,
+}
+
+impl FromStr for CsvQuoteStyle {
+ type Err = DataFusionError;
+
+ fn from_str(s: &str) -> Result<Self, Self::Err> {
+ match s {
+ "Always" | "ALWAYS" | "always" => Ok(Self::Always),
+ "Necessary" | "NECESSARY" | "necessary" | "" =>
Ok(Self::Necessary),
+ "NonNumeric" | "NON_NUMERIC" | "nonnumeric" =>
Ok(Self::NonNumeric),
+ "Never" | "NEVER" | "never" => Ok(Self::Never),
+ _ => Err(DataFusionError::NotImplemented(format!(
+ "Unsupported CSV quote style {s}"
+ ))),
+ }
Review Comment:
I'll quickly check what spark does here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
