gabotechs commented on code in PR #21670:
URL: https://github.com/apache/datafusion/pull/21670#discussion_r3092179794
##########
Cargo.toml:
##########
@@ -192,7 +192,7 @@ strum = "0.28.0"
strum_macros = "0.28.0"
tempfile = "3"
testcontainers-modules = { version = "0.15" }
-tokio = { version = "1.51", features = ["macros", "rt", "sync"] }
+tokio = { version = "1.52", features = ["macros", "rt", "sync"] }
Review Comment:
This should be fine 👍, but just want to double check something first:
The `tokio = "1.51"` version declaration in DataFusion is already compatible
with consumers having `tokio = "1.52"` on their project, meaning that you
should be already able use `tokio = "1.52"` in your codebase depending on
DataFusion without this PR. In other words, having `tokio = "1.51"` here is
like DataFusion saying to the outside world "I support `tokio` 1.X as long as X
>= 51"
Did you find any issues with that that require bumping the minimum supported
version here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
