gabotechs commented on code in PR #21670:
URL: https://github.com/apache/datafusion/pull/21670#discussion_r3092316035


##########
Cargo.toml:
##########
@@ -192,7 +192,7 @@ strum = "0.28.0"
 strum_macros = "0.28.0"
 tempfile = "3"
 testcontainers-modules = { version = "0.15" }
-tokio = { version = "1.51", features = ["macros", "rt", "sync"] }
+tokio = { version = "1.52", features = ["macros", "rt", "sync"] }

Review Comment:
   I did some digging, and it seems that Dependabot is configured in this 
project with a very aggressive minimum minor supported version for dependencies.
   
   Actually, `tokio` itself was just bumped last week in 
https://github.com/apache/datafusion/pull/21435/changes#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542L195-R195.
   
   While this is not the configuration I'd recommend for a project, it's what 
we have today in DataFusion, so this PR should be good to go 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to