zhuqi-lucas commented on code in PR #21580:
URL: https://github.com/apache/datafusion/pull/21580#discussion_r3093080432
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -1223,9 +1230,20 @@ impl RowGroupsPrunedParquetOpen {
// Prepare the access plan (extract row groups and row selection)
let mut prepared_plan = access_plan.prepare(rg_metadata)?;
- // Potentially reverse the access plan for performance.
- // See `ParquetSource::try_pushdown_sort` for the rationale.
- if prepared.reverse_row_groups {
+ // Reorder row groups by statistics if sort order is known.
Review Comment:
Good suggestion! Addressed in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
