asolimando commented on code in PR #21122:
URL: https://github.com/apache/datafusion/pull/21122#discussion_r3093883429
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -2769,15 +2771,30 @@ impl DefaultPhysicalPlanner {
// to verify that the plan fulfills the base requirements.
InvariantChecker(InvariantLevel::Always).check(&plan)?;
+ let use_expression_analyzer = session_state
+ .config_options()
+ .optimizer
+ .use_expression_analyzer;
let mut new_plan = Arc::clone(&plan);
for optimizer in optimizers {
let before_schema = new_plan.schema();
+ let plan_before_rule = Arc::clone(&new_plan);
new_plan = optimizer
.optimize_with_context(new_plan, session_state)
.map_err(|e| {
DataFusionError::Context(optimizer.name().to_string(),
Box::new(e))
})?;
+ // Re-inject ExpressionAnalyzer registry into any exec nodes
created or replaced by
+ // this rule. Skip if the rule returned the same plan unchanged to
+ // avoid an O(nodes) walk for no-op rules.
+ if use_expression_analyzer && !Arc::ptr_eq(&plan_before_rule,
&new_plan) {
Review Comment:
Addressed as 1. in
https://github.com/apache/datafusion/pull/21122#discussion_r3093089736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
