sgrebnov commented on code in PR #21296:
URL: https://github.com/apache/datafusion/pull/21296#discussion_r3095194312
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -3468,4 +3468,58 @@ mod tests {
}
Ok(())
}
+
+ #[test]
+ fn test_bigquery_dialect_overrides() -> Result<()> {
+ let bigquery_dialect: Arc<dyn Dialect> =
Arc::new(BigQueryDialect::new());
+ let unparser = Unparser::new(bigquery_dialect.as_ref());
+
+ // date_field_extract_style: EXTRACT instead of date_part
+ let expr = Expr::ScalarFunction(ScalarFunction {
+ func: Arc::new(ScalarUDF::new_from_impl(
+ datafusion_functions::datetime::date_part::DatePartFunc::new(),
+ )),
+ args: vec![lit("YEAR"), col("date_col")],
+ });
+ let actual = format!("{}", unparser.expr_to_sql(&expr)?);
+ assert_eq!(actual, "EXTRACT(YEAR FROM `date_col`)");
+
+ // interval_style: SQL standard instead of PostgresVerbose
+ let expr = interval_year_month_lit("3 months");
+ let actual = format!("{}", unparser.expr_to_sql(&expr)?);
+ assert_eq!(actual, "INTERVAL '3' MONTH");
+
+ // float64_ast_dtype: FLOAT64 instead of DOUBLE
+ let expr = cast(col("a"), DataType::Float64);
+ let actual = format!("{}", unparser.expr_to_sql(&expr)?);
+ assert_eq!(actual, "CAST(`a` AS FLOAT64)");
+
+ // supports_column_alias_in_table_alias: false
+ assert!(!bigquery_dialect.supports_column_alias_in_table_alias());
+
+ // utf8_cast_dtype: STRING instead of VARCHAR
+ let expr = cast(col("a"), DataType::Utf8);
+ let actual = format!("{}", unparser.expr_to_sql(&expr)?);
+ assert_eq!(actual, "CAST(`a` AS STRING)");
+
+ // large_utf8_cast_dtype: STRING instead of TEXT
+ let expr = cast(col("a"), DataType::LargeUtf8);
+ let actual = format!("{}", unparser.expr_to_sql(&expr)?);
+ assert_eq!(actual, "CAST(`a` AS STRING)");
+
+ // int64_cast_dtype: INT64 instead of BIGINT
+ let expr = cast(col("a"), DataType::Int64);
+ let actual = format!("{}", unparser.expr_to_sql(&expr)?);
+ assert_eq!(actual, "CAST(`a` AS INT64)");
Review Comment:
Thank you @nuno-faria 🙏 - you are right, `BigInt` is supported, I've double
checked one more time manually, I might misspelled it previously - propose to
remove this override as unnecessary. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
