mbutrovich commented on issue #21543: URL: https://github.com/apache/datafusion/issues/21543#issuecomment-4262653945
So the TPC-H and TPC-DS results in https://github.com/apache/datafusion/pull/21629 are very exciting but I am concerned about regressions with string types (not string view) and generally wide schemas. I wonder: - should we only coalesce sort expression columns, convert those to rows, then map those back to their original batches for the `take`? I think joins do something similar when join keys span input batches - should we do something data-type specific? It's hard to find a general solution here :( Sorts are fun. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
