adriangb commented on PR #21633: URL: https://github.com/apache/datafusion/pull/21633#issuecomment-4262673968
> I would personally recommend also doing some sort "end to end" test -- specifically setup a sort of StringView data that was mostly sliced and ensure the spill files ar enot huge I don't know that there is anything like that in DataFusion. Do you think it's needed for this PR or just a general idea? Anecdotally we've had this PR cherry picked for months and it does fix the issues we've seen in production. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
